Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "add html5 attributes to email fields of the config manager" #279

Merged
merged 1 commit into from Aug 11, 2013

Conversation

Chris--S
Copy link
Collaborator

@Chris--S Chris--S commented Aug 8, 2013

@selfthinker
Copy link
Collaborator

👍

splitbrain added a commit that referenced this pull request Aug 11, 2013
Revert "add html5 attributes to email fields of the config manager"
@splitbrain splitbrain merged commit 8c1faba into master Aug 11, 2013
@splitbrain splitbrain deleted the FS#2833 branch August 11, 2013 09:58
@Chris--S
Copy link
Collaborator Author

oh. i discussed with selfthinker and thought using noformvalidation was the way to go after all.

@splitbrain
Copy link
Collaborator

well that discussion never reached me ;-) I just had her 👍 and the comments in the bug report.

@Chris--S
Copy link
Collaborator Author

On 12 Aug 2013, at 15:31, Andreas Gohr notifications@github.com wrote:

well that discussion never reached me ;-) I just had her and the comments in the bug report.

I don't know why she did that :/

@selfthinker
Copy link
Collaborator

I never said we should go with formnovalidate. Because @splitbrain mentioned it in the bug report, @Chris--S asked me what I thought of that. And I said that there might be a point in doing it. But I don't think it's worth it.

splitbrain pushed a commit that referenced this pull request Apr 9, 2020
Add compareValue() to AbstractBaseType & Lookup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants